Hello Iru Cai,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34639
to review the following change.
Change subject: ec/lenovo/h8: Add an option to set F1-F12 as primary function ......................................................................
ec/lenovo/h8: Add an option to set F1-F12 as primary function
Tested on Lenovo ThinkPad T440p.
Change-Id: I83dc2c19341475abeeacd374a1b6cf152ec9b497 Signed-off-by: Iru Cai mytbk920423@gmail.com --- M src/ec/lenovo/h8/h8.c 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/34639/1
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index 2b959ce..46b83b6 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -86,6 +86,14 @@ ec_clr_bit(0x0, 3); }
+static void f1_to_f12_as_primary(int on) +{ + if (on) + ec_set_bit(0x3b, 3); + else + ec_clr_bit(0x3b, 3); +} + static void h8_log_ec_version(void) { char ecfw[17]; @@ -334,6 +342,9 @@ val = 0; h8_sticky_fn(val);
+ if (get_option(&val, "f1_to_f12_as_primary") == CB_SUCCESS) + f1_to_f12_as_primary(val); + if (get_option(&val, "first_battery") != CB_SUCCESS) val = PRIMARY_BATTERY; h8_charge_priority(val);