Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )
Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset
......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 6: Code-Review-1
The usb config is per-variant, this needs to go in overridetree. I have some patches coming to define all the usb ports.
Hi Ducan,
gpio-reset using A-13 across all TGL variants. cant we place in baseboard? Overridetree from each platform is must? pls provide the feedback.
The USB port setup is not the same across all variants (it is for BT but not the other ports) so it needs to go in overridetree. as mentioned I have some patches coming to configure the USB ACPI for all variants.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46825
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8
Gerrit-Change-Number: 46825
Gerrit-PatchSet: 6
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 27 Oct 2020 16:53:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment