[coreboot-gerrit] Change in coreboot[master]: binaryPI: implement C bootblock

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36914 )

Change subject: binaryPI: implement C bootblock
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36914/8/src/drivers/amd/agesa/cache... 
File src/drivers/amd/agesa/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/36914/8/src/drivers/amd/agesa/cache... 
PS8, Line 114: #else
Maybe just use a different file and let the Makefile do its job?

https://review.coreboot.org/c/coreboot/+/36914/8/src/drivers/amd/agesa/cache... 
PS8, Line 142: OSFXSR [
> Right. Would it be feasible to add it to bootblock_crt0.S? And most important, why bootblock_crt0 doesn't clear the FPU emulation bit? In fact I have copied this comment from cpu/x86/fpu_enable.inc and I wonder how true this statement is with #UD

You can just set those bits in c code before calling AGESA if you want btw.