Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34976 )
Change subject: cpu/intel/car: Make stack guards more useful on C_ENV_BOOTBLOCK ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34976/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34976/5//COMMIT_MSG@16 PS5, Line 16: the stack_base is at the base of CAR. If the stack grows too large it
nit: rewrap lines ?
Done
https://review.coreboot.org/c/coreboot/+/34976/3/src/cpu/intel/car/romstage.... File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/34976/3/src/cpu/intel/car/romstage.... PS3, Line 41: of CAR. To make stack guards useful, move them up 256 bytes */
Ah. Crap, this was the proper comment style. Just end the sentence with dot.
Ack
https://review.coreboot.org/c/coreboot/+/34976/5/src/cpu/intel/car/romstage.... File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/34976/5/src/cpu/intel/car/romstage.... PS5, Line 23:
Are you okay with 0x2000 if we keep this line and add comment?
Done
https://review.coreboot.org/c/coreboot/+/34976/5/src/cpu/intel/car/romstage.... PS5, Line 43: _car_stack_end
_car_stack_end - 0x2000 was the location of the stack guards before this change (DCACHE_RAM_RO […]
Increased guards to 256 bytes but forgot to add new comment.