Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33583 )
Change subject: mb/google/hatch: Do not pull down GPP_F2 internally
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33583/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33583/1//COMMIT_MSG@9
PS1, Line 9: There is already an external pull-up/down resistor
Is this true for all variants?
I checked Hatch, Helios, Kohaku, and Kindred. All of them have external resistors on GPP_F2.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33583
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6
Gerrit-Change-Number: 33583
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:04:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment