Attention is currently required from: Kane Chen, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60401 )
Change subject: soc/intel/alderlake: Check clkreq overlap ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60401/comment/78e26577_66e07889 PS4, Line 13: add `adds`
https://review.coreboot.org/c/coreboot/+/60401/comment/6fdb0aaa_390c025e PS4, Line 13: pop up `shows`
Patchset:
PS4: Good idea!
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/60401/comment/022ecd95_f3f261ad PS4, Line 55: uint16_t You say a 32-bit mapping in the comment above but this is a uint16_t.
You could just change the comment to say a bitmask and then change this variable to an `unsigned int`; the machine word width is plenty of bits either way.