Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44165 )
Change subject: superio/ite: configure EC for fans to full at thermal limit ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44165/1/src/superio/ite/common/env_... File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/44165/1/src/superio/ite/common/env_... PS1, Line 151: ITE_EC_FAN_CTL_FULL_AT_THRML_LMT(conf->full_lmt)); this overwrites what the function call in the lines above set. you probably need to or the two settings that go in the same register together and write it in one command. there might have been some commit introducing a command to only write certain bits of a register; don't remember exactly though
https://review.coreboot.org/c/coreboot/+/44165/1/src/superio/ite/common/env_... File src/superio/ite/common/env_ctrl_chip.h:
https://review.coreboot.org/c/coreboot/+/44165/1/src/superio/ite/common/env_... PS1, Line 60: limit */
please, no space before tabs
that should fit all in one line; the characters per line limit was raised to 96 some time ago