16 Oct
2020
16 Oct
'20
2:49 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45451 )
Change subject: nb/intel/gm45: Introduce memmap.h ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45451/3/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/memmap.h:
https://review.coreboot.org/c/coreboot/+/45451/3/src/northbridge/intel/gm45/... PS3, Line 10:
That's more a how than why, isn't it? ;)
It answers why, and also explains that this line wasn't always `additional`. If you want me to remove it, just say so next time.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45451
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idddb63069b7a0b7b4d6c7850473a71318748bb9b
Gerrit-Change-Number: 45451
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 16 Oct 2020 09:49:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment