Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42413 )
Change subject: cpu/intel/206ax/acpi.c: Fix get_cores_per_package
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42413/3/src/cpu/intel/model_206ax/a...
File src/cpu/intel/model_206ax/acpi.c:
https://review.coreboot.org/c/coreboot/+/42413/3/src/cpu/intel/model_206ax/a...
PS3, Line 21: logical_cores = msr.lo & 0xffff;
Excuse my ignorance, but why is the `& 0xffff` needed? […]
Well, it's how it returns data. Bits [31:16] are cores count and [15:0] are threads count. We need threads so 0xffff.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42413
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib32c2d40408cfa42ca43ab42ed661c168e579ada
Gerrit-Change-Number: 42413
Gerrit-PatchSet: 4
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jun 2020 09:59:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment