Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33775 )
Change subject: arch/x86: Adjust size of postcar stack
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33775/4/src/mainboard/emulation/qemu-i440fx/...
File src/mainboard/emulation/qemu-i440fx/romstage.c:
https://review.coreboot.org/#/c/33775/4/src/mainboard/emulation/qemu-i440fx/...
PS4, Line 17: #include <arch/cpu.h>
You do not need this include anymore since you have removed the define for the default stack size in […]
Right, I did not spot the missing header elsewhere, I will update once there is review for the parent (FSP1_1) commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33775
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba1fb5bfad6946f316feac2d8c998a782142a56a
Gerrit-Change-Number: 33775
Gerrit-PatchSet: 4
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Mon, 01 Jul 2019 04:53:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment