Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42077 )
Change subject: soc/intel/common/block: Enable PMC IPC driver ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42077/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42077/5//COMMIT_MSG@13 PS5, Line 13: 141608957
151731851?
Yeah seems I still was referencing the old bug
https://review.coreboot.org/c/coreboot/+/42077/5//COMMIT_MSG@15 PS5, Line 15: TEST:
TEST=
Done
https://review.coreboot.org/c/coreboot/+/42077/5/src/soc/intel/common/block/... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/42077/5/src/soc/intel/common/block/... PS5, Line 29: RBUT
typo
Done
https://review.coreboot.org/c/coreboot/+/42077/5/src/soc/intel/common/block/... PS5, Line 44: 1000
nit: 1 * MSECS_PER_SEC (see src/include/timer. […]
Done
https://review.coreboot.org/c/coreboot/+/42077/5/src/soc/intel/common/block/... PS5, Line 640: udelay(50);
blank line after if statement please
Done