Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39690 )
Change subject: mb/ocp/tiogapass: Configure IPMI FRB2 watchdog timer via VPD variables ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39690/4/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/ramstage.c:
https://review.coreboot.org/c/coreboot/+/39690/4/src/mainboard/ocp/tiogapass... PS4, Line 33: init_frb2_wdt
is this functionality specific to this motherboard only, all other OCP boards use same thing?
The starting and stopping IPMI watchdog part is the standard IPMI BMC watchdog, which should be board independent. The VPD variable reading part so far is only implemented for Mono Lake and Tioga Pass, this is to mimick the FRB2 timer configuration feature in UEFI BIOS.