Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41624 )
Change subject: drivers/intel/mipi_camera: SSDT add camera power resource
......................................................................
Patch Set 23:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41624/18/src/drivers/intel/mipi_cam...
File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/41624/18/src/drivers/intel/mipi_cam...
PS18, Line 189: const char *pr0;
: const char *pr3;
I have made this changes, waiting on the test results before I push the changes.
Done
https://review.coreboot.org/c/coreboot/+/41624/16/src/drivers/intel/mipi_cam...
File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/41624/16/src/drivers/intel/mipi_cam...
PS16, Line 185: const char *pr3;
@Matt I have made the changes to remove PR3, I will be pushing the changes as part of next CL. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41624
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31e198b50acf2c64035aff9cb054fbe3602dd83e
Gerrit-Change-Number: 41624
Gerrit-PatchSet: 23
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kiran2 Kumar
kiran2.kumar@intel.corp-partner.google.com
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 22 Jun 2020 08:52:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt Delco
delco@chromium.org
Comment-In-Reply-To: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment