Hello Aaron Durbin, Patrick Rudolph, Julius Werner, Frans Hendriks, Hung-Te Lin, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Werner Zeh, Huang Jin, Daisuke Nojiri, Lee Leahy, Philipp Deppenwiese, Joel Kitching,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36543
to look at the new patch set (#4).
Change subject: security/vboot: Removed vboot_prepare from vboot_locator ......................................................................
security/vboot: Removed vboot_prepare from vboot_locator
When prog_locate() is called in the stage VBOOT is starting from and the image to be loaded is not the target image vboot_prepare() may be called too early.
To prevent this vboot_prepare() is removed from the vboot_locator structure. This allows more control over the start of the vboot logic.
To clarify the change the vboot_prepare() has been renamed to vboot_run_logic() and calls to initialize vboot have been added at the following places:
postcar_loader: when VBOOT starts in ROMSTAGE romstage_loader: when VBOOT starts in BOOTBLOCK ramstage_loader: when VBOOT starts in ROMSTAGE
BUG=N/A TEST=tested on facebook fbg1701
Change-Id: Id5e8fd78458c09dd3896bfd142bd49c2c3d686df Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/arch/x86/postcar_loader.c M src/lib/prog_loaders.c M src/security/vboot/vboot_common.h M src/security/vboot/vboot_loader.c 4 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/36543/4