Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32777 )
Change subject: mainboard/google/sarien: set diagnostic LEDs on boot failure
......................................................................
Patch Set 5:
You might move some of this to the EC so it can be reused easier. It is a bit odd since the mainboard is the one that can intercept the post codes, but that could be passed to the EC.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32777
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If865ab8203f89e499130f4677fec166b40d80174
Gerrit-Change-Number: 32777
Gerrit-PatchSet: 5
Gerrit-Owner: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 May 2019 17:55:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment