Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46862 )
Change subject: drivers/wifi/generic: Add support for CNVi dummy device ops ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/46862/1/src/drivers/wifi/generic/ac... File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/46862/1/src/drivers/wifi/generic/ac... PS1, Line 250: dev->enabled could use is_dev_enabled() but this is consistent with the pcie version so it seems ok.
https://review.coreboot.org/c/coreboot/+/46862/1/src/drivers/wifi/generic/wi... File src/drivers/wifi/generic/wifi_private.h:
https://review.coreboot.org/c/coreboot/+/46862/1/src/drivers/wifi/generic/wi... PS1, Line 7: smbios_write_cnvi maybe smbios_write_wifi_cnvi() would be more clear, but this is is in a local header so it doesn't really matter.