Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43766 )
Change subject: security/vboot/Makefile.inc: Update regions-for-file function
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43766/5/src/security/vboot/Makefile...
File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43766/5/src/security/vboot/Makefile...
PS5, Line 174: $(if $(value regions-for-file-$(1)), \
Do you mean as below? […]
This is what the logic looks like in pseudo-C:
```
if (regions-for-file-$(1)) {
regions-for-file-$(1)
} else {
if (filter (if (filter y, $(CONFIG_VBOOT...), \
$/romstage,) \
}
```
which is why I think lines 175 and 176 should be indented the same amount.
but I think the indentation that was already here is incorrect anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43766
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f5c22b3d9558ee3c5daa2781a115964f8d2d83b
Gerrit-Change-Number: 43766
Gerrit-PatchSet: 6
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Jul 2020 22:06:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment