Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36145 )
Change subject: arch/arm: Pass cbmem_top to ramstage via calling argument
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36145/15/src/arch/arm/stages.c
File src/arch/arm/stages.c:
https://review.coreboot.org/c/coreboot/+/36145/15/src/arch/arm/stages.c@32
PS15, Line 32: uintptr_t _cbmem_top_ptr;
Why can't the x86 stages do this as well? Why put it in assembler? […]
It doesn't need a similar function. It just needs to set the variable. You are allocating and setting the variable in the assembly when you only need the latter. The cbmem_top.c compilation unit can hold the object itself, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36145
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If31f0f1de17ffc92c9397f32b26db25aff4b7cab
Gerrit-Change-Number: 36145
Gerrit-PatchSet: 15
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Tue, 29 Oct 2019 21:34:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment