Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Weimin Wu, Karthik Ramasubramanian. Zhi7 Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for ALC5682I-VD & VS ......................................................................
Patch Set 10:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56930/comment/d52accad_7694fa8e PS6, Line 7: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
I have modified this place
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/56930/comment/88486882_40dfb092 PS9, Line 7: mb/google/dedede/var/sasukette:Add
Please add a space after the colon.
Done
https://review.coreboot.org/c/coreboot/+/56930/comment/95dfdfeb_ed485c1c PS9, Line 8: codec ALC5682I-VD & VS compatibility
Please put it on one line.
Done
https://review.coreboot.org/c/coreboot/+/56930/comment/41560c51_43298e61 PS9, Line 10: Change the `_HID` value depending on the the fw_config values
Please elaborate, and maybe note, where you copied this from.
Done
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56930/comment/4d5fc526_2e48cbe9 PS7, Line 29: config->hid = "RTL5682";
I have modified this place.
Done