Attention is currently required from: Michał Żygowski, Patrick Georgi, Paul Menzel.
Markus Meissner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78299?usp=email )
Change subject: Documentation: add Nitrokey to distributions ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78299/comment/eeabb734_6c9a2355 : PS1, Line 9: Coreboot
Please spell it lowercase.
Acknowledged
Patchset:
PS1:
Thank you. […]
sorted the list alphabetically & fixed orthography as suggested
File Documentation/distributions.md:
https://review.coreboot.org/c/coreboot/+/78299/comment/dae42dd4_babc6a1a : PS1, Line 14: Coreboot
Ditto.
Acknowledged
https://review.coreboot.org/c/coreboot/+/78299/comment/2fbc375c_ad3c5f8c : PS1, Line 19: e-mail
Acknowledged
File Documentation/distributions.md:
https://review.coreboot.org/c/coreboot/+/78299/comment/f8ce3c1d_f30684cb : PS3, Line 23: offers a range of laptops, PCs, HSM, and networking devices with coreboot and : [Dasharo](https://dasharo.com/).
`offers a range of laptops, PCs, and networking devices with coreboot/[Dasharo](https://dasharo. […]
In fact the HSMs is running Coreboot, it's a network HSM, called NetHSM running a coreboot (on a hermes prodrive), muen, mirage stack.
Anyways, the reason it is a singular is there is only one variant (model) for HSM, while for the others (laptops, PCs) there are multiple models available. Although from linguistics point of view it is indeed weird to have both (plural and singular) in one sentence.
I have no strong opinion on this, so what should we stick to?