Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48566 )
Change subject: soc/intel/alderlake: Drop unreferenced devicetree settings
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/48566/1/src/soc/intel/alderlake/chi...
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/48566/1/src/soc/intel/alderlake/chi...
PS1, Line 181: GraphicsConfigPtr
This gets filled with the value from `vbt_get()` in fsp_params. […]
Or rather, it sets the UPD directly... yeah I guess this will probably not get used except for VBTs, but can easily be added back if necessary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4cf88a482f840edf16e2ac42e6ab61eccfba0aa
Gerrit-Change-Number: 48566
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Dec 2020 17:42:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment