Attention is currently required from: Michał Żygowski, Frans Hendriks, Arthur Heymans, Wim Vervoorn.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59754 )
Change subject: mb/facebook/fbg1701: Remove ONBOARD_SAMSUNG_MEM
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/facebook/fbg1701/romstage.c:
https://review.coreboot.org/c/coreboot/+/59754/comment/22f362c4_9b8d1d3f
PS2, Line 30: break;
i would prefer if you set spd_index = 0 here right before the break, so it's less implicit what this will end up doing
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59754
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21b5ddc430410a1e8b3e9012d0c07d278880ff47
Gerrit-Change-Number: 59754
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Comment-Date: Wed, 01 Dec 2021 14:53:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment