[coreboot-gerrit] [XL] Change in coreboot[main]: soc/mediatek/mt8196: Add thermal driver

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86017?usp=email )

Change subject: soc/mediatek/mt8196: Add thermal driver
......................................................................

Patch Set 2:

(5 comments)

File src/soc/mediatek/mt8196/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/86017/comment/6a793bd9_7511c7b3?usp... :
PS2, Line 46: romstage-y += pmif_spmi.c
            : romstage-y += srclken_rc.c
            : romstage-y += mt_thermal.c
            : romstage-y += mt_thermal_sram_init.c
sort

File src/soc/mediatek/mt8196/mt_thermal.c:

https://review.coreboot.org/c/coreboot/+/86017/comment/0647b075_a9bdffd2?usp... :
PS2, Line 7: #include <stddef.h>
           : #include <stdlib.h>
           : #include <stdio.h>
           : #include <string.h>
what are those for ?
please include `console/console.h` for `printk`

https://review.coreboot.org/c/coreboot/+/86017/comment/7412ea5e_2ae58613?usp... :
PS2, Line 318: 0x%x,
%#x

File src/soc/mediatek/mt8196/mt_thermal_sram_init.c:

https://review.coreboot.org/c/coreboot/+/86017/comment/80559f64_c0014e2f?usp... :
PS2, Line 32: int i = 0;
            : 	uint32_t pattern = 0xffffffff;
            : 	uint32_t *buff = (uint32_t *)THERMAL_STAT_SRAM_BASE;
            : 	for (i = 0; i < THERMAL_STAT_SRAM_LEN / 4; i++) {
            : 		*buff = pattern;
            : 		buff++;
            : 	}
> Would it be better to align the same style with thermal_cls_sram() function?

I don't think that is necessary.

https://review.coreboot.org/c/coreboot/+/86017/comment/e394bbd8_95a91d25?usp... :
PS2, Line 48: int i = 0;
            : 	uint32_t pattern = 0xffffffff;
            : 	uint32_t *buff = (uint32_t *)GPU_THERMAL_STAT_SRAM_BASE;
            : 	for (i = 0; i < GPU_THERMAL_STAT_SRAM_LEN / 4; i++) {
            : 		*buff = pattern;
            : 		buff++;
            : 	}
> Would it be better to align the same style with thermal_cls_sram() function?

I don't think that is necessary.