27 Aug
2019
27 Aug
'19
6:17 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/20979 )
Change subject: nb/intel/x4x/raminit: Move dummy reads after JEDEC init ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/20979/8/src/northbridge/intel/x4x/r... File src/northbridge/intel/x4x/raminit_ddr23.c:
https://review.coreboot.org/c/coreboot/+/20979/8/src/northbridge/intel/x4x/r... PS8, Line 2163: (ch << 29) | (r * 0x08000000)
I wonder why this was lost when moving the code. […]
FYI: I'm waiting for this to be addressed before I'll give this patch a +2
--
To view, visit https://review.coreboot.org/c/coreboot/+/20979
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8069f9c08ad5e5268ddbe3711d58bc42522f938c
Gerrit-Change-Number: 20979
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 28 Aug 2019 01:17:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment