Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44077 )
Change subject: drivers/intel/fsp2_0: Do AP re-init after FSP-S if USE_INTEL_FSP_MP_INIT enable
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44077/5/src/drivers/intel/fsp2_0/fs...
File src/drivers/intel/fsp2_0/fsp_mpinit.c:
https://review.coreboot.org/c/coreboot/+/44077/5/src/drivers/intel/fsp2_0/fs...
PS5, Line 8: Ps back the full AP re-initialization
: * required
back, A full AP re-initialization is required
https://review.coreboot.org/c/coreboot/+/44077/5/src/drivers/intel/fsp2_0/in...
File src/drivers/intel/fsp2_0/include/fsp/api.h:
https://review.coreboot.org/c/coreboot/+/44077/5/src/drivers/intel/fsp2_0/in...
PS5, Line 80: required
nit: back, A full AP re-initialization is required after FSP is completed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44077
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I247d8d1166c77bd01922323b6a0f14ec6640a666
Gerrit-Change-Number: 44077
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 31 Jul 2020 09:39:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment