Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40733 )
Change subject: md/tiogapass: move all *.h to dir and make them global
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40733/6/src/mainboard/ocp/tiogapass...
File src/mainboard/ocp/tiogapass/romstage.c:
https://review.coreboot.org/c/coreboot/+/40733/6/src/mainboard/ocp/tiogapass...
PS6, Line 19: include/skxsp_tp_iio.h"
I think we usually just add -Ifoo in the makefiles to avoid "" include
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40733
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e3ef5882d6cb0ddbcb8357b54106ff2f47e4c51
Gerrit-Change-Number: 40733
Gerrit-PatchSet: 8
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Thu, 30 Apr 2020 21:44:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-MessageType: comment