[coreboot-gerrit] [L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable

[Benjamin Doron (Code Review)]

Attention is currently required from: Sean Rhodes, Nico Huber, Angel Pons, Maximilian Brune, Lean Sheng Tan.

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )

Change subject: [RFC] drivers/option: Add option list in cbtable
......................................................................

Patch Set 4:

(2 comments)

Patchset:

PS3:
> Patchset 4 allows forms to be nested, which can be used to group settings like you mentioned. […]

Forms have a start and end, but so long as I can write them as a structure and copy them in as raw HII, nested forms will work when I make the processing recursive. As we realised, it should probably update the outer form correctly, with all new forms. Except it's triggering an assert at the moment, we'll see.

To my knowledge, formsets cannot be nested. Since we compile a small formset to insert items into, there already is one formset. So, the only way to do this, *if necessary*, is to build the entire VfrBin array at runtime.

File src/drivers/option/cfr.c:

https://review.coreboot.org/c/coreboot/+/74121/comment/f39e4ad4_3a688a05 
PS3, Line 103: option_id
> Done

Oh, this is why it's in the frontend too.