[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: add spmfw loader

[Yidi Lin (Code Review)]

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )

Change subject: soc/mediatek/mt8192: add spmfw loader
......................................................................

Patch Set 34:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46389/33/src/soc/mediatek/mt8192/Ma... 
File src/soc/mediatek/mt8192/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/46389/33/src/soc/mediatek/mt8192/Ma... 
PS33, Line 53: cbfs-files-y += spm_firmware.bin
             : spm_firmware.bin-file := $(MT8192_BLOB_DIR)/spm_firmware.bin
             : spm_firmware.bin-type := raw
             : spm_firmware.bin-compression := $(CBFS_COMPRESS_FLAG)
> If we will be adding a lot of firmware files like this, I think we should: […]

Done

https://review.coreboot.org/c/coreboot/+/46389/33/src/soc/mediatek/mt8192/sp... 
File src/soc/mediatek/mt8192/spm.c:

https://review.coreboot.org/c/coreboot/+/46389/33/src/soc/mediatek/mt8192/sp... 
PS33, Line 498: cbfs_boot_load_file
> The parsing code requires file_size for checking offset. […]

Ack