Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45838 )
Change subject: soc/intel/xeon_sp/acpi: Move ACPI macros to a header file
......................................................................
Patch Set 3:
Also note that buildbot is unhappy with the MACROs (which it doesn't check in .asl file), but the text replace magic doesn't work right if I try to change these. Maybe someone can work the MACRO magic in a future commit.
No code is changing in this commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45838
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2441763fe335154048c9a584a227a18e8c5391c
Gerrit-Change-Number: 45838
Gerrit-PatchSet: 3
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Oct 2020 19:09:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment