11 May
2019
11 May
'19
11:28 p.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32753 )
Change subject: mb/lenovo/s230u: Rewrite trigger inversion ACPI code ......................................................................
Patch Set 2:
(1 comment)
I find it rather weird to have the hardware invert the value of the gpio input, instead of relying on software to deal with it...
https://review.coreboot.org/#/c/32753/2/src/mainboard/lenovo/s230u/acpi/gpe.... File src/mainboard/lenovo/s230u/acpi/gpe.asl:
https://review.coreboot.org/#/c/32753/2/src/mainboard/lenovo/s230u/acpi/gpe.... PS2, Line 46: ( space needed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32753
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac5dfb71b3a2b5a25c05a403cf5f403c7acecaaf
Gerrit-Change-Number: 32753
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth martinroth@google.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tobias Diedrich ranma+coreboot@tdiedrich.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 11 May 2019 21:28:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment