[coreboot-gerrit] Change in coreboot[master]: cbfstool: Build vboot library

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39390 )

Change subject: cbfstool: Build vboot library
......................................................................

Patch Set 9:
> Patch Set 9:
> Hmm... yeah, I don't really understand what's happening there. Maybe it's some weird race condition with parallel make?
>
> Patrick, can you help?

There's a race condition between creating the binary and using it. The simple fix for this is to compile to cbfstool.tmp first, then mv into the real location, because mv is an atomic operation.

But: it will likely fail because there will be multiple writers to coreboot.tmp then. abuild (which is called by the what-jenkins-does target, which is what the builder does) first runs "make tools" (with tons of options) in util/abuild/abuild:839 to avoid that issue.

For some reason this change creates a perceived need to rebuild cbfstool for every board.