Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32753 )
Change subject: mb/lenovo/s230u: Rewrite trigger inversion ACPI code
......................................................................
Patch Set 3:
(1 comment)
I find it rather weird to have the hardware invert the value of the
gpio input, instead of relying on software to deal with it...
I'd have to go look at the datasheet, but I think this is just switching the level that it triggers on. It reads the GPIO value and reverses the trigger accordingly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32753
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac5dfb71b3a2b5a25c05a403cf5f403c7acecaaf
Gerrit-Change-Number: 32753
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tobias Diedrich
ranma+coreboot@tdiedrich.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 11 May 2019 22:09:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment