[coreboot-gerrit] Change in coreboot[master]: sc7180: GPIO: Add I2S configuration for sc7180

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38593 )

Change subject: sc7180: GPIO: Add I2S configuration for sc7180
......................................................................

Patch Set 21:

(7 comments)

https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@7 
PS21, Line 7:  for sc7180
Already in the prefix, but the prefix should be:
> google/trogdor:

https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@8 
PS21, Line 8: 
Please add a problem description. Something like:
> The audio speaker does not work on Trogdor revision 1, as the
> layout was changed.

https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@9 
PS21, Line 9: Audio
audio

https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@9 
PS21, Line 9: Configuring
Configure

https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@9 
PS21, Line 9: Configuring GPIO Pins as I2S mode for Audio speaker.
… as per schematics?

https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@9 
PS21, Line 9: Pins
pins

https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@10 
PS21, Line 10: 
Is there a bug for this issue. Please add it as reference.