Attention is currently required from: Bao Zheng, Felix Held, Julius Werner, Zheng Bao.
Maximilian Brune has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/85590?usp=email )
Change subject: amdfwtool: Add combo_index into context
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
Patchset:
PS8:
I tested: building birman-plus (using BUILD_TIMELESS) there is no binary change (as expected).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85590?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4b026b0630a18d1f46bff98ffe5f11e7f930d7a8
Gerrit-Change-Number: 85590
Gerrit-PatchSet: 8
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 04 Feb 2025 14:22:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes