Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 61:
(57 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/cc9b03f8_6334ec9f PS61, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/466eca50_d1b08f9a PS61, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/43b03682_28719be6 PS61, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/53697ba9_7f802b02 PS61, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/4cbea449_79a58dc3 PS61, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/5011e6e0_5edffe50 PS61, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/945aeedb_8ace455f PS61, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/3f0fb2dc_9907f5f4 PS61, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/8244d755_afba109a PS61, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/c4a72075_a04159f8 PS61, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/98e5d352_a058f636 PS61, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/df93b81f_2bd94d6b PS61, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/5956e4eb_51cfa00d PS61, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/fad63cd5_53485bb9 PS61, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwE820.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/2c34fc09_783d5a67 PS61, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwEc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/2ee2f25f_e9d3576e PS61, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/b8c17170_c1319726 PS61, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIo.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/54e3a07f_eea29010 PS61, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/352b5e99_cc59777c PS61, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIoIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/c87845a2_3077be5b PS61, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/76196c79_d4b9e384 PS61, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwMemory.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/aa96b3dc_b93d4bc9 PS61, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/467d3c19_10793d03 PS61, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwMemoryIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/65ab97a3_84f5ea9e PS61, Line 34: struct nuklear_memory_index_data_view *this = (struct nuklear_memory_index_data_view *) obj; line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/b16dc4ea_420b6641 PS61, Line 37: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/fcace0d3_6621c8d2 PS61, Line 40: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/5fb02b6a_e4b31058 PS61, Line 73: struct nuklear_memory_index_data_view *this = (struct nuklear_memory_index_data_view *) obj; line length of 100 exceeds 96 columns
File payloads/cbui/NuklearUI/NuklearRwNvram.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/a122ff90_ecaa34f9 PS61, Line 37: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/545f957c_c496fe97 PS61, Line 40: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/72a9cc6c_ddcea595 PS61, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/06baac03_3211e93f PS61, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/1d1ebded_7ddfdae5 PS61, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/df7ad0fd_8f7c009d PS61, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/289acdc4_701592d0 PS61, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/feb18cf2_0df1e82b PS61, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/18ef6304_81570ba0 PS61, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/e84da7ad_821e5b89 PS61, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/4e437a32_5af8081f PS61, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/57c18844_a3ce935b PS61, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/a070ab2c_1de5d98e PS61, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/b518b4b0_8b532e6c PS61, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/5bf42141_a20eda55 PS61, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/2d0ee577_695f2a95 PS61, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/526a6ac3_27279dda PS61, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/571718f2_83b20c3f PS61, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/8cb081e0_1d12fd8b PS61, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/ef77ed71_8d6a0587 PS61, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/50dcbd7e_16edf7af PS61, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/42ee8dab_a83a2ea7 PS61, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/2d77f5c2_fb015d12 PS61, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/ee470708_5bc025b7 PS61, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/cefde127_63101ed6 PS61, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/380f66d7_80d07e26 PS61, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/a4be8b12_cbc752c6 PS61, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/57a6ad8e_eed0c7f2 PS61, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/fa13ae54_5b7f8e94 PS61, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159895): https://review.coreboot.org/c/coreboot/+/23586/comment/6a8c2022_ae3aa614 PS61, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const