Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 )
Change subject: mb/ongy/h61m-s1: Add new mainboard ......................................................................
Patch Set 11:
(10 comments)
Patch Set 10:
Patch Set 10:
(4 comments)
When I want to commit changes, I have a message from lint:
check Kconfig files for errors (lint-stable-008-kconfig): #!!!!! Error: Undefined Symbol 'BOARD_ONGY_H61M_S1' used at src/mainboard/ongy/h61m-s1/Kconfig:4. but it is not an error
How can I handle this? --> done with this
I now have a executable bite bit all my files are 644 and folders 755. What is the problem? I don't undersand where is the executable bit
https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG@7 PS10, Line 7: adding new mainboard : ported with autoport script
Use the imperative, e.g. […]
Done
https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG@13 PS10, Line 13: USB boot (USB 2.0 only - USB 3.0 works sometimes but not always, don't why yet - Works when OS is loaded)
Description has a character limit 72 per line.
Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig:
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/Kconfig... PS10, Line 1: if VENDOR_ONGY
Add a line break here
Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 6: register "gpu_cpu_backlight" = "0x00000000"
I think you can remove
Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 10: register "gpu_panel_port_select" = "0" : register "gpu_panel_power_backlight_off_delay" = "0" : register "gpu_panel_power_backlight_on_delay" = "0"
default values. […]
Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 14: register "gpu_panel_power_down_delay" = "0" : register "gpu_panel_power_up_delay" = "0" : register "gpu_pch_backlight" = "0x00000000"
this is default. […]
Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 34: register "gen2_dec" = "0x00000000" : register "gen3_dec" = "0x00000000" : register "gen4_dec" = "0x00000000"
maybe you can remove
Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 4: #define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
is it used?
yes, it seems to be used for integrated GPU
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c:
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 4: #include <stdint.h> : #include <string.h> : #include <timestamp.h> : #include <arch/byteorder.h> : #include <device/mmio.h> : #include <device/pci_ops.h> : #include <device/pnp_ops.h> : #include <console/console.h> : #include <bootblock_common.h> : #include <northbridge/intel/sandybridge/sandybridge.h> : #include <northbridge/intel/sandybridge/raminit_native.h> : #include <southbridge/intel/bd82x6x/pch.h> : #include <southbridge/intel/common/gpio.h>
Please remove unused includes
Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 1: /* : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2.0-only */ […]
Done