Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36093 )
Change subject: mb/lenovo/x200: Add ThinkPad X301 as a variant ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36093/4/Documentation/mainboard/len... File Documentation/mainboard/lenovo/x301.md:
https://review.coreboot.org/c/coreboot/+/36093/4/Documentation/mainboard/len... PS4, Line 7: replaces
replaced
Done
https://review.coreboot.org/c/coreboot/+/36093/4/Documentation/mainboard/len... PS4, Line 21: (you might need to add the chip to the IFD VSCC list)
If you can match the ID's found the the VSCC table to the chip names in flashrom and create a list h […]
Add what is found in vendor IFD VSCC list.
https://review.coreboot.org/c/coreboot/+/36093/4/src/mainboard/lenovo/x200/K... File src/mainboard/lenovo/x200/Kconfig:
https://review.coreboot.org/c/coreboot/+/36093/4/src/mainboard/lenovo/x200/K... PS4, Line 26: select H8_DOCK_EARLY_INIT if BOARD_LENOVO_X301
No please don't use this and link an empty implementation of the function. […]
Reverted to the scheme of the previous patchset.