Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48156 )
Change subject: arch/x86: Don't use .bss from car.ld if not running XIP
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48156/1/src/include/rules.h
File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/48156/1/src/include/rules.h@266
PS1, Line 266: ENV_ROMSTAGE || ENV_SEPARATE_VERSTAGE
Why only these? Why can't we just
#define ENV_STAGE_XIP (ENV_ROMSTAGE_OR_BEFORE && !CONFIG(NO_XIP_EARLY_STAGES))
independent of the arch?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48156
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6cf51f943dde5f642d75ba4c5d3be520dc56370a
Gerrit-Change-Number: 48156
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 06 Dec 2020 17:01:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment