Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23135 )
Change subject: superio: Add ASpeed AST2400 ......................................................................
Patch Set 19:
(4 comments)
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/ast2400/ast2400.... File src/superio/aspeed/ast2400/ast2400.h:
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/ast2400/ast2400.... PS17, Line 21: #include <arch/io.h>
no need for arch/io. […]
Done
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/ast2400/ast2400.... PS17, Line 22: #include <superio/aspeed/common/aspeed.h>
why include it here if it's only linked in romstage?
Done
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/ast2400/ast2400.... PS17, Line 32: #define AST2400_MAILBOX 0xE /* Mailbox */
one more tab to align with ILPC2AHB
Done
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/common/aspeed.h File src/superio/aspeed/common/aspeed.h:
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/common/aspeed.h@... PS17, Line 21: #include <arch/io.h>
no need for arch/io. […]
Done