Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Rob Barnes, Fred Reitberger, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62402 )
Change subject: soc/amd/{common/vboot,cezanne}: Copy S0i3 verstage logs into cbmem
......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/common/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/62402/comment/e58d6e2c_47b3c89d
PS6, Line 15: $(src)/soc/amd/common/vboot/early_ram_symbols.awk
I think the error message might be more readable if this is left off. […]
Which error message? We need to add it as a dep, otherwise changing the .awk won't cause the .ld file to be rebuilt. I'm not sure if there is a helper to map the current directory. i.e., $(src-to-obj)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62402
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64d33ccdee9863270cfbcaef5d7c614349bd895c
Gerrit-Change-Number: 62402
Gerrit-PatchSet: 6
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 08 Mar 2022 15:47:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment