Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )
Change subject: soc/mediatek: dsi: Fix EoTp flag ......................................................................
Patch Set 11:
(5 comments)
https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@9 PS11, Line 9: Soc SoC
https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@9 PS11, Line 9: ( One space before "("
https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@10 PS11, Line 10: setup set
https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@14 PS11, Line 14: Boots correctly on Kukui Something else related to b/168728787 should be tested. For example,
TEST=Display is normal on Kukui
https://review.coreboot.org/c/coreboot/+/48868/11/src/soc/mediatek/common/ds... File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/48868/11/src/soc/mediatek/common/ds... PS11, Line 157: tmp_reg |= (mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) << 6; Let's also rewrite this to
if (mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) tmp_reg |= SOMETHING;
where SOMETHING should be BIT(16).