Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36921 )
Change subject: soc/mediatek/mt8183: TX RX window should not do fast K for High frequency ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36921/3/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/36921/3/src/soc/mediatek/mt8183/dra... PS3, Line 1593: 796
how this was calculated? I know it's freq/2, but why -4 ? can you add some comment?
the real CK DRAMC output is 796,1196,1596,1972, NOT 800,1200,1400,1866 Dram Type= 6, Freq= 796, FreqGroup= 800, CH_0, rank 0 Dram Type= 6, Freq= 1596, FreqGroup= 1600, CH_0, rank 0 Dram Type= 6, Freq= 1792, FreqGroup= 1866, CH_0, rank 1
https://review.coreboot.org/c/coreboot/+/36921/3/src/soc/mediatek/mt8183/dra... PS3, Line 1648: clock_rate
this looks like doubled. […]
this place need using clock rate do computer, so NOT need /2