Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33749 )
Change subject: soc/amd/picasso: Change all remaining soc names ......................................................................
Patch Set 2:
(15 comments)
It looks like you intentionally left out XHCI and GEC firmwares. Why?
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Kconfig@154 PS2, Line 154: STONEYRIDGE PICASSO
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Kconfig@155 PS2, Line 155: Stoney Ridge Picasso
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Kconfig@164 PS2, Line 164: STONEYRIDGE PICASSO
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Kconfig@168 PS2, Line 168: Stoney Ridge Picasso
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Kconfig@170 PS2, Line 170: STONEYRIDGE PICASSO
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Kconfig@174 PS2, Line 174: Stoney Ridge Picasso
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Kconfig@180 PS2, Line 180: STONEYRIDGE PICASSO
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Kconfig@182 PS2, Line 182: STONEYRIDGE PICASSO
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Kconfig@184 PS2, Line 184: TONEYRIDGE PICASSO
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Makefile.inc File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Makefile.inc@178 PS2, Line 178: OPT_STONEYRIDGE_XHCI_FWM_FILE=$(call add_opt_prefix, $(CONFIG_STONEYRIDGE_XHCI_FWM_FILE), --xhci) : OPT_STONEYRIDGE_GEC_FWM_FILE=$(call add_opt_prefix, $(CONFIG_STONEYRIDGE_GEC_FWM_FILEddd), --gec) : PICASSO (4 places)
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Makefile.inc@200 PS2, Line 200: STONEYRIDGE PICASSO
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Makefile.inc@201 PS2, Line 201: STONEYRIDGE PICASSO
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Makefile.inc@220 PS2, Line 220: STONEYRIDG PICASSO
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/Makefile.inc@221 PS2, Line 221: STONEYRIDGE PICASSO
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/southbridge.c File src/soc/amd/picasso/southbridge.c:
https://review.coreboot.org/#/c/33749/2/src/soc/amd/picasso/southbridge.c@80 PS2, Line 80: STONEYRIDGE PICASSO