17 Jul
2020
17 Jul
'20
12:42 p.m.
Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43087 )
Change subject: mb/bostentech: Add GBYT4 port ......................................................................
Patch Set 26:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43087/18/src/mainboard/bostentech/g... File src/mainboard/bostentech/gbyt4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43087/18/src/mainboard/bostentech/g... PS18, Line 78: io 0x60 = 0x0a30
Wait, is said fan controlled by the Super I/O? If so, I'd keep the LDN
It's only an unused fan header, and I can't tell if it's on the SuperIO without more testing. I will keep the LDN for now just in case.
--
To view, visit https://review.coreboot.org/c/coreboot/+/43087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99ed0c94c3255578151f940ad9b274e6f0816bfe
Gerrit-Change-Number: 43087
Gerrit-PatchSet: 26
Gerrit-Owner: Máté Kukri kukri.mate@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Jul 2020 10:42:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Máté Kukri kukri.mate@gmail.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment