Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45190 )
Change subject: mb/google/dedede/var/drawcia: probe TABLEMODE bit to add mipi camera
......................................................................
Patch Set 11: -Code-Review
Thinking about it further, I don't think probing for TABLET mode is not the right approach to enable MIPI camera. You might want to consider provisioning the FW_CONFIG with camera information.
I am withdrawing my +2.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45190
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35dcc7bb82ceb014fd40b794ccf190b226061281
Gerrit-Change-Number: 45190
Gerrit-PatchSet: 11
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: Andy Yeh
andy.yeh@intel.com
Gerrit-CC: Henry Sun
henrysun@google.com
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Oct 2020 17:14:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment