Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39411 )
Change subject: soc/intel: fix eist enabling
......................................................................
Patch Set 1:
This change basically takes the direction that Aaron suggested in the skylake fix. I sympathize with the hesitation of that fix's author to add another read and write of an MSR, but 1) I don't see a way to avoid it without making larger changes to the common abstractions, and 2) I doubt anyone will notice the additional overhead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39411
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4651eda46a064dfb59797ac8e1cb8c38bb8e38c
Gerrit-Change-Number: 39411
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 09 Mar 2020 23:16:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment