Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48640 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 max speed
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48640/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48640/1//COMMIT_MSG@10
PS1, Line 10: 4000MHz
Are there CooperLake CPUs with a faster speed? If not, I would move this into xeon_sp code
Yes, there're CooperLake CPUs with faster speed.
https://review.coreboot.org/c/coreboot/+/48640/1/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/48640/1/src/mainboard/ocp/deltalake...
PS1, Line 101: /* This will return 4000MHz */
: return 0xfa0;
return 4000;
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67edf657a2fe66b38e08056d558e1b360c4b8adc
Gerrit-Change-Number: 48640
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Dec 2020 12:53:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment