Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38986 )
Change subject: WIP: xeonsp: Add common IIO-related code
......................................................................
Patch Set 8:
(2 comments)
Intel document Reference Number: 329595-002 seems to cover a few registers, but no implementation details.
https://review.coreboot.org/c/coreboot/+/38986/8/src/cpu/intel/xeonsp/iio.c
File src/cpu/intel/xeonsp/iio.c:
https://review.coreboot.org/c/coreboot/+/38986/8/src/cpu/intel/xeonsp/iio.c@...
PS8, Line 394: static void get_iiostack_info(struct iiostack_resource *info)
why is this data read from FSP instead of devicetree or PCI space?
https://review.coreboot.org/c/coreboot/+/38986/8/src/cpu/intel/xeonsp/iio.c@...
PS8, Line 534: n
isn't a "stack" simply an MMCONF address area or a subregion of that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38986
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c459fc5deb885c5f979499b75dc95633bb6c00f
Gerrit-Change-Number: 38986
Gerrit-PatchSet: 8
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Feb 2020 07:42:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment