Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 3:
(9 comments)
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 33: MAYBE_STATIC_NONZERO uint32_t sku = -1;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 33: MAYBE_STATIC_NONZERO uint32_t sku = -1;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 35: if (sku == -1)
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 35: if (sku == -1)
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 36: sku = google_chromeec_get_sku_id();
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 36: sku = google_chromeec_get_sku_id();
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 38: return sku;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 38: return sku;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/1/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35214/1/src/mainboard/google/kahlee... PS1, Line 28: sku_id
I wonder if we should update ec_boardid.c (https://review.coreboot.org/cgit/coreboot. […]
Done