Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46141 )
Change subject: soc/intel/common: Add PCI driver for USB4 ports ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46141/7/src/soc/intel/common/block/... File src/soc/intel/common/block/usb4/usb4.c:
https://review.coreboot.org/c/coreboot/+/46141/7/src/soc/intel/common/block/... PS7, Line 18: .ops_pci = &pci_dev_ops_pci, nit: We should also add `.acpi_name` support here. I am thinking eventually we should get rid of having a big if-else/switch case in SoC chip.c to return ACPI names for all controllers and instead have the appropriate driver generate both the device node(`acpi_fill_ssdt`) as well as return its ACPI name(`acpi_name`).